President Trump called for ending the so-called carried interest loophole, which saves financiers billions. It’s a tax break that has survived time after time.